[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 32:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/11579/32/apps/app_audiosocket.c 
File apps/app_audiosocket.c:

https://gerrit.asterisk.org/c/asterisk/+/11579/32/apps/app_audiosocket.c@111 
PS32, Line 111: 	if (ast_set_write_format(chan, ast_format_slin)) {
              : 		ast_log(LOG_ERROR, "Failed to set write format to SLINEAR for channel %s\n", chanName);
              : 		ao2_ref(writeFormat, -1);
              : 		ao2_ref(readFormat, -1);
              : 		return -1;
              : 	}
              : 	if (ast_set_read_format(chan, ast_format_slin)) {
              : 		ast_log(LOG_ERROR, "Failed to set read format to SLINEAR for channel %s\n", chanName);
              : 
              : 		/* Attempt to restore previous write format even though it is likely to
              : 		 * fail, since setting the read format did.
              : 		 */
              : 		if (ast_set_write_format(chan, writeFormat)) {
              : 			ast_log(LOG_ERROR, "Failed to restore write format for channel %s\n", chanName);
              : 		}
              : 		ao2_ref(writeFormat, -1);
              : 		ao2_ref(readFormat, -1);
              : 		return -1;
              : 	}
> This is the "calling" channel yes?  If so is this going to cause a renegoation with the caller?
I ran a test to see, just sending a ulaw channel into this application, and it didn't look like there was a renegotiation occurring... Should there be? Codec remained ulaw after this as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 32
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 15:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191212/d8bc5c1d/attachment.html>