[Asterisk-code-review] Warning when app_voicemail is compiling (asterisk[13.29])

Kevin Harwell asteriskteam at digium.com
Tue Dec 10 13:55:33 CST 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13413 )

Change subject: Warning when app_voicemail is compiling
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13413/3//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13413/3//COMMIT_MSG@12 
PS3, Line 12: 
            : Sorry, it is my first patch to review
            : how to remove all files except "apps/app_voicemail.c"?
> I did clone from branch 13.29.2 uses command […]
It gave that error because 13.29.2 is not a branch, but a tag. Most of the time you'll want to be working from one of the mainline branches (13, 16, 17, or master), or a local branch based from one of those. So for instance, in this case the normal process goes something like this (after a repo has been cloned):

$ git checkout 13
$ git checkout -b <ASTERISK issue id>

Make you changes, compile, and test.

$ git add <files(s) changed>
$ git commit
$ git review 13

More info, and examples here:

https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13.29
Gerrit-Change-Id: Id1014c8e5067178b2a773497e62014f18790c0aa
Gerrit-Change-Number: 13413
Gerrit-PatchSet: 6
Gerrit-Owner: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 19:55:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191210/9cbdf774/attachment.html>


More information about the asterisk-code-review mailing list