[Asterisk-code-review] Update for 13.29.2 (asterisk[13])
Stanislav Abramenkov
asteriskteam at digium.com
Tue Dec 10 12:36:21 CST 2019
Stanislav Abramenkov has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/13413 )
Change subject: Update for 13.29.2
......................................................................
Update for 13.29.2
Change-Id: Id1014c8e5067178b2a773497e62014f18790c0aa
---
M .version
M ChangeLog
M apps/app_voicemail.c
D asterisk-13.29.1-summary.html
D asterisk-13.29.1-summary.txt
A asterisk-13.29.2-summary.html
A asterisk-13.29.2-summary.txt
7 files changed, 219 insertions(+), 119 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/13/13413/1
diff --git a/.version b/.version
index b4a7f3e..602e060 100644
--- a/.version
+++ b/.version
@@ -1 +1 @@
-13.29.1
\ No newline at end of file
+13.29.2
\ No newline at end of file
diff --git a/ChangeLog b/ChangeLog
index 0b48a70..ca9dc4a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,67 @@
+2019-11-21 21:07 +0000 Asterisk Development Team <asteriskteam at digium.com>
+
+ * asterisk 13.29.2 Released.
+
+2019-11-21 15:04 +0000 [24d340e10a] Asterisk Development Team <asteriskteam at digium.com>
+
+ * Update CHANGES and UPGRADE.txt for 13.29.2
+2019-10-24 12:41 +0000 [94a831f72a] George Joseph <gjoseph at digium.com>
+
+ * manager.c: Prevent the Originate action from running the Originate app
+
+ If an AMI user without the "system" authorization calls the
+ Originate AMI command with the Originate application,
+ the second Originate could run the "System" command.
+
+ Action: Originate
+ Channel: Local/1111
+ Application: Originate
+ Data: Local/2222,app,System,touch /tmp/owned
+
+ If the "system" authorization isn't set, we now block the
+ Originate app as well as the System, Exec, etc. apps.
+
+ ASTERISK-28580
+ Reported by: Eliel Sardañons
+
+ Change-Id: Ic4c9dedc34c426f03c8c14fce334a71386d8a5fa
+ (cherry picked from commit 1b9281a5ded62e5d30af2959e5aa33bc5a0fc285)
+
+2019-10-21 14:55 +0000 [c265db0a0a] Ben Ford <bford at digium.com>
+
+ * chan_sip.c: Prevent address change on unauthenticated SIP request.
+
+ If the name of a peer is known and a SIP request is sent using that
+ peer's name, the address of the peer will change even if the request
+ fails the authentication challenge. This means that an endpoint can
+ be altered and even rendered unusuable, even if it was in a working
+ state previously. This can only occur when the nat option is set to the
+ default, or auto_force_rport.
+
+ This change checks the result of authentication first to ensure it is
+ successful before setting the address and the nat option.
+
+ ASTERISK-28589 #close
+
+ Change-Id: I581c5ed1da60ca89f590bd70872de2b660de02df
+ (cherry picked from commit c2279540bade208dad35f7760ebd4a7cc94731fe)
+
+2019-11-08 13:21 +0000 [cde0cd2297] Ben Ford <bford at digium.com>
+
+ * res_pjsip_session.c: Check for port of zero on incoming SDP.
+
+ If a re-invite comes in initiating T.38, but there is no c line in the
+ SDP and the port is also 0, a crash can occur. A check is now done on
+ the port to see if the steam is already declined, preventing the crash.
+ The logic was moved to res_pjsip_session.c because it is handled in a
+ similar manner in later versions of Asterisk.
+
+ ASTERISK-28612
+ Reported by: Salah Ahmed
+
+ Change-Id: Ifc4a0d05b32c7f2156e77fc8435a6ecaa6abada0
+ (cherry picked from commit c257794330db49f4079a7108d51da60696269b36)
+
2019-10-16 15:48 +0000 Asterisk Development Team <asteriskteam at digium.com>
* asterisk 13.29.1 Released.
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index a51c3c7..1e43836 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -13556,7 +13556,8 @@
astman_send_listack(s, m, "Voicemail user list will follow", "start");
AST_LIST_TRAVERSE(&users, vmu, list) {
- int new, old;
+ int new = 0;
+ int old = 0;
int ret;
char *mailbox;
diff --git a/asterisk-13.29.1-summary.html b/asterisk-13.29.1-summary.html
deleted file mode 100644
index ddc6bcf..0000000
--- a/asterisk-13.29.1-summary.html
+++ /dev/null
@@ -1,20 +0,0 @@
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><title>Release Summary - asterisk-13.29.1</title><h1 align="center"><a name="top">Release Summary</a></h1><h3 align="center">asterisk-13.29.1</h3><h3 align="center">Date: 2019-10-16</h3><h3 align="center"><asteriskteam at digium.com></h3><hr><h2 align="center">Table of Contents</h2><ol>
-<li><a href="#summary">Summary</a></li>
-<li><a href="#contributors">Contributors</a></li>
-<li><a href="#closed_issues">Closed Issues</a></li>
-<li><a href="#diffstat">Diffstat</a></li>
-</ol><hr><a name="summary"><h2 align="center">Summary</h2></a><center><a href="#top">[Back to Top]</a></center><p>This release is a point release of an existing major version. The changes included were made to address problems that have been identified in this release series, or are minor, backwards compatible new features or improvements. Users should be able to safely upgrade to this version if this release series is already in use. Users considering upgrading from a previous version are strongly encouraged to review the UPGRADE.txt document as well as the CHANGES document for information about upgrading to this release series.</p><p>The data in this summary reflects changes that have been made since the previous release, asterisk-13.29.0.</p><hr><a name="contributors"><h2 align="center">Contributors</h2></a><center><a href="#top">[Back to Top]</a></center><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.</p><table width="100%" border="0">
-<tr><th width="33%">Coders</th><th width="33%">Testers</th><th width="33%">Reporters</th></tr>
-<tr valign="top"><td width="33%">1 Kevin Harwell <kharwell at digium.com><br/>1 George Joseph <gjoseph at digium.com><br/></td><td width="33%"><td width="33%">1 Joshua Elson <joshelson at gmail.com><br/>1 Niklas Larsson<br/>1 Niklas Larsson <niklas at tese.se><br/></td></tr>
-</table><hr><a name="closed_issues"><h2 align="center">Closed Issues</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p><h3>Bug</h3><h4>Category: Resources/res_pjsip_mwi</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-28575">ASTERISK-28575</a>: MWI Send Notify Crash on 16.6<br/>Reported by: Joshua Elson<ul>
-<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=2f6504ce5ea5fda21d23623e0d4f390337686baa">[2f6504ce5e]</a> Kevin Harwell -- res_pjsip_mwi: potential double unref, and potential unwanted double link</li>
-</ul><br><h4>Category: pjproject/pjsip</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-28574">ASTERISK-28574</a>: pjproject fails to build on 16.6.0, works on 16.5<br/>Reported by: Niklas Larsson<ul>
-<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=1fd9f80cae200aa73e032a35ac6c0a8257444499">[1fd9f80cae]</a> George Joseph -- pjproject_bundled: Replace earlier reverts with official fixes.</li>
-</ul><br><hr><a name="diffstat"><h2 align="center">Diffstat Results</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p><pre>b/res/res_pjsip_mwi.c | 15
-b/third-party/pjproject/patches/0030-ssl-regression-fix.patch | 105 +
-b/third-party/pjproject/patches/0031-transport-regression-fix.patch | 187 +
-third-party/pjproject/patches/0030-Revert-Misc-re-2147-Fixed-warnings-in-SSL-socket-red.patch | 60
-third-party/pjproject/patches/0031-Revert-Fixed-2204-Add-OpenSSL-remote-certificate-cha.patch | 84
-third-party/pjproject/patches/0032-Revert-Re-2147-misc-Fix-failed-pjsip-test-transport_.patch | 64
-third-party/pjproject/patches/0033-Revert-Close-1019-Support-for-multiple-listeners.patch | 1006 ----------
-7 files changed, 303 insertions(+), 1218 deletions(-)</pre><br></html>
\ No newline at end of file
diff --git a/asterisk-13.29.1-summary.txt b/asterisk-13.29.1-summary.txt
deleted file mode 100644
index 3c4d9c5..0000000
--- a/asterisk-13.29.1-summary.txt
+++ /dev/null
@@ -1,97 +0,0 @@
- Release Summary
-
- asterisk-13.29.1
-
- Date: 2019-10-16
-
- <asteriskteam at digium.com>
-
- ----------------------------------------------------------------------
-
- Table of Contents
-
- 1. Summary
- 2. Contributors
- 3. Closed Issues
- 4. Diffstat
-
- ----------------------------------------------------------------------
-
- Summary
-
- [Back to Top]
-
- This release is a point release of an existing major version. The changes
- included were made to address problems that have been identified in this
- release series, or are minor, backwards compatible new features or
- improvements. Users should be able to safely upgrade to this version if
- this release series is already in use. Users considering upgrading from a
- previous version are strongly encouraged to review the UPGRADE.txt
- document as well as the CHANGES document for information about upgrading
- to this release series.
-
- The data in this summary reflects changes that have been made since the
- previous release, asterisk-13.29.0.
-
- ----------------------------------------------------------------------
-
- Contributors
-
- [Back to Top]
-
- This table lists the people who have submitted code, those that have
- tested patches, as well as those that reported issues on the issue tracker
- that were resolved in this release. For coders, the number is how many of
- their patches (of any size) were committed into this release. For testers,
- the number is the number of times their name was listed as assisting with
- testing a patch. Finally, for reporters, the number is the number of
- issues that they reported that were affected by commits that went into
- this release.
-
- Coders Testers Reporters
- 1 Kevin Harwell 1 Joshua Elson
- 1 George Joseph 1 Niklas Larsson
- 1 Niklas Larsson
-
- ----------------------------------------------------------------------
-
- Closed Issues
-
- [Back to Top]
-
- This is a list of all issues from the issue tracker that were closed by
- changes that went into this release.
-
- Bug
-
- Category: Resources/res_pjsip_mwi
-
- ASTERISK-28575: MWI Send Notify Crash on 16.6
- Reported by: Joshua Elson
- * [2f6504ce5e] Kevin Harwell -- res_pjsip_mwi: potential double unref,
- and potential unwanted double link
-
- Category: pjproject/pjsip
-
- ASTERISK-28574: pjproject fails to build on 16.6.0, works on 16.5
- Reported by: Niklas Larsson
- * [1fd9f80cae] George Joseph -- pjproject_bundled: Replace earlier
- reverts with official fixes.
-
- ----------------------------------------------------------------------
-
- Diffstat Results
-
- [Back to Top]
-
- This is a summary of the changes to the source code that went into this
- release that was generated using the diffstat utility.
-
- b/res/res_pjsip_mwi.c | 15
- b/third-party/pjproject/patches/0030-ssl-regression-fix.patch | 105 +
- b/third-party/pjproject/patches/0031-transport-regression-fix.patch | 187 +
- third-party/pjproject/patches/0030-Revert-Misc-re-2147-Fixed-warnings-in-SSL-socket-red.patch | 60
- third-party/pjproject/patches/0031-Revert-Fixed-2204-Add-OpenSSL-remote-certificate-cha.patch | 84
- third-party/pjproject/patches/0032-Revert-Re-2147-misc-Fix-failed-pjsip-test-transport_.patch | 64
- third-party/pjproject/patches/0033-Revert-Close-1019-Support-for-multiple-listeners.patch | 1006 ----------
- 7 files changed, 303 insertions(+), 1218 deletions(-)
diff --git a/asterisk-13.29.2-summary.html b/asterisk-13.29.2-summary.html
new file mode 100644
index 0000000..41db88f
--- /dev/null
+++ b/asterisk-13.29.2-summary.html
@@ -0,0 +1,25 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><title>Release Summary - asterisk-13.29.2</title><h1 align="center"><a name="top">Release Summary</a></h1><h3 align="center">asterisk-13.29.2</h3><h3 align="center">Date: 2019-11-21</h3><h3 align="center"><asteriskteam at digium.com></h3><hr><h2 align="center">Table of Contents</h2><ol>
+<li><a href="#summary">Summary</a></li>
+<li><a href="#contributors">Contributors</a></li>
+<li><a href="#closed_issues">Closed Issues</a></li>
+<li><a href="#commits">Other Changes</a></li>
+<li><a href="#diffstat">Diffstat</a></li>
+</ol><hr><a name="summary"><h2 align="center">Summary</h2></a><center><a href="#top">[Back to Top]</a></center><p>This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.</p><p>Security Advisories:</p><ul>
+<li><a href="http://downloads.asterisk.org/pub/security/AST-2019-006,AST-2019-007,AST-2019-008.html">AST-2019-006,AST-2019-007,AST-2019-008</a></li>
+</ul><p>The data in this summary reflects changes that have been made since the previous release, asterisk-13.29.1.</p><hr><a name="contributors"><h2 align="center">Contributors</h2></a><center><a href="#top">[Back to Top]</a></center><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.</p><table width="100%" border="0">
+<tr><th width="33%">Coders</th><th width="33%">Testers</th><th width="33%">Reporters</th></tr>
+<tr valign="top"><td width="33%">2 Ben Ford <bford at digium.com><br/>1 Asterisk Development Team <asteriskteam at digium.com><br/>1 George Joseph <gjoseph at digium.com><br/></td><td width="33%"><td width="33%">1 Salah Ahmed<br/>1 Eliel Sardañons <eliels at gmail.com><br/>1 Andrey V. T. <avt1203 at gmail.com><br/>1 Eliel Sardañons<br/>1 Salah Ahmed <txrubel at gmail.com><br/></td></tr>
+</table><hr><a name="closed_issues"><h2 align="center">Closed Issues</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p><h3>Security</h3><h4>Category: Channels/chan_sip/General</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-28589">ASTERISK-28589</a>: chan_sip: Depending on configuration an INVITE can alter Addr of a peer<br/>Reported by: Andrey V. T.<ul>
+<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=c265db0a0a6e6128297402c3540b0162a86e210c">[c265db0a0a]</a> Ben Ford -- chan_sip.c: Prevent address change on unauthenticated SIP request.</li>
+</ul><br><h4>Category: Core/ManagerInterface</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-28580">ASTERISK-28580</a>: Bypass SYSTEM write permission in manager action allows system commands execution<br/>Reported by: Eliel Sardañons<ul>
+<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=94a831f72afe3c7ff0806848d731332ee49fc2d4">[94a831f72a]</a> George Joseph -- manager.c: Prevent the Originate action from running the Originate app</li>
+</ul><br><h3>Bug</h3><h4>Category: Resources/res_pjsip_t38</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-28612">ASTERISK-28612</a>: res_pjsip_t38: crash on reinvite with zero port and no c= line<br/>Reported by: Salah Ahmed<ul>
+<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=cde0cd229706aa8509f995765578fbfdbe13015d">[cde0cd2297]</a> Ben Ford -- res_pjsip_session.c: Check for port of zero on incoming SDP.</li>
+</ul><br><hr><a name="commits"><h2 align="center">Commits Not Associated with an Issue</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all changes that went into this release that did not reference a JIRA issue.</p><table width="100%" border="1">
+<tr><th>Revision</th><th>Author</th><th>Summary</th></tr>
+<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=24d340e10a4e66a2a4428f0554ee583dcfd031da">24d340e10a</a></td><td>Asterisk Development Team</td><td>Update CHANGES and UPGRADE.txt for 13.29.2</td></tr>
+</table><hr><a name="diffstat"><h2 align="center">Diffstat Results</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p><pre>UPGRADE.txt | 10 ++++++++++
+channels/chan_sip.c | 28 ++++++++++++++++------------
+main/manager.c | 1 +
+res/res_pjsip_session.c | 2 ++
+4 files changed, 29 insertions(+), 12 deletions(-)</pre><br></html>
\ No newline at end of file
diff --git a/asterisk-13.29.2-summary.txt b/asterisk-13.29.2-summary.txt
new file mode 100644
index 0000000..55393fb
--- /dev/null
+++ b/asterisk-13.29.2-summary.txt
@@ -0,0 +1,127 @@
+ Release Summary
+
+ asterisk-13.29.2
+
+ Date: 2019-11-21
+
+ <asteriskteam at digium.com>
+
+ ----------------------------------------------------------------------
+
+ Table of Contents
+
+ 1. Summary
+ 2. Contributors
+ 3. Closed Issues
+ 4. Other Changes
+ 5. Diffstat
+
+ ----------------------------------------------------------------------
+
+ Summary
+
+ [Back to Top]
+
+ This release has been made to address one or more security vulnerabilities
+ that have been identified. A security advisory document has been published
+ for each vulnerability that includes additional information. Users of
+ versions of Asterisk that are affected are strongly encouraged to review
+ the advisories and determine what action they should take to protect their
+ systems from these issues.
+
+ Security Advisories:
+
+ * AST-2019-006,AST-2019-007,AST-2019-008
+
+ The data in this summary reflects changes that have been made since the
+ previous release, asterisk-13.29.1.
+
+ ----------------------------------------------------------------------
+
+ Contributors
+
+ [Back to Top]
+
+ This table lists the people who have submitted code, those that have
+ tested patches, as well as those that reported issues on the issue tracker
+ that were resolved in this release. For coders, the number is how many of
+ their patches (of any size) were committed into this release. For testers,
+ the number is the number of times their name was listed as assisting with
+ testing a patch. Finally, for reporters, the number is the number of
+ issues that they reported that were affected by commits that went into
+ this release.
+
+ Coders Testers Reporters
+ 2 Ben Ford 1 Salah Ahmed
+ 1 Asterisk Development Team 1 Eliel Sardañons
+ 1 George Joseph 1 Andrey V. T.
+ 1 Eliel Sardañons
+ 1 Salah Ahmed
+
+ ----------------------------------------------------------------------
+
+ Closed Issues
+
+ [Back to Top]
+
+ This is a list of all issues from the issue tracker that were closed by
+ changes that went into this release.
+
+ Security
+
+ Category: Channels/chan_sip/General
+
+ ASTERISK-28589: chan_sip: Depending on configuration an INVITE can alter
+ Addr of a peer
+ Reported by: Andrey V. T.
+ * [c265db0a0a] Ben Ford -- chan_sip.c: Prevent address change on
+ unauthenticated SIP request.
+
+ Category: Core/ManagerInterface
+
+ ASTERISK-28580: Bypass SYSTEM write permission in manager action allows
+ system commands execution
+ Reported by: Eliel Sardañons
+ * [94a831f72a] George Joseph -- manager.c: Prevent the Originate action
+ from running the Originate app
+
+ Bug
+
+ Category: Resources/res_pjsip_t38
+
+ ASTERISK-28612: res_pjsip_t38: crash on reinvite with zero port and no c=
+ line
+ Reported by: Salah Ahmed
+ * [cde0cd2297] Ben Ford -- res_pjsip_session.c: Check for port of zero
+ on incoming SDP.
+
+ ----------------------------------------------------------------------
+
+ Commits Not Associated with an Issue
+
+ [Back to Top]
+
+ This is a list of all changes that went into this release that did not
+ reference a JIRA issue.
+
+ +------------------------------------------------------------------------+
+ | Revision | Author | Summary |
+ |------------+---------------------------+-------------------------------|
+ | 24d340e10a | Asterisk Development Team | Update CHANGES and |
+ | | | UPGRADE.txt for 13.29.2 |
+ +------------------------------------------------------------------------+
+
+ ----------------------------------------------------------------------
+
+ Diffstat Results
+
+ [Back to Top]
+
+ This is a summary of the changes to the source code that went into this
+ release that was generated using the diffstat utility.
+
+ UPGRADE.txt | 10 ++++++++++
+ channels/chan_sip.c | 28 ++++++++++++++++------------
+ main/manager.c | 1 +
+ res/res_pjsip_session.c | 2 ++
+ 4 files changed, 29 insertions(+), 12 deletions(-)
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id1014c8e5067178b2a773497e62014f18790c0aa
Gerrit-Change-Number: 13413
Gerrit-PatchSet: 1
Gerrit-Owner: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191210/bdc292c9/attachment-0001.html>
More information about the asterisk-code-review
mailing list