[Asterisk-code-review] res_rtp_asterisk: implement ACL mechanism for ICE and STUN addresses. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Tue Dec 10 07:03:54 CST 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13309 )

Change subject: res_rtp_asterisk: implement ACL mechanism for ICE and STUN addresses.
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@2987 
PS4, Line 2987: 		if ((val = ast_variable_retrieve(cfg, section, opt))) {
There can be multiple acl/deny/permit/blacklist specified, doesn't this fail under that scenario by only retrieving a single variable?


https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@2994 
PS4, Line 2994: 	if (acl_subscription_flag && !acl_change_sub) {
If no ACLs are configured does it make sense to not have this subscription occur?


https://gerrit.asterisk.org/c/asterisk/+/13309/4/res/res_rtp_asterisk.c@6898 
PS4, Line 6898: 	rtp_reload(1, 1);
Can't you just call rtp_load_acl for each?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13309
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id57a8df51fcfd3bd85ea67c489c85c6c3ecd7b30
Gerrit-Change-Number: 13309
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191210/7d14dd4f/attachment.html>


More information about the asterisk-code-review mailing list