[Asterisk-code-review] res_pjsip_nat: Restore original contact for REGISTER responses (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12824 )

Change subject: res_pjsip_nat: Restore original contact for REGISTER responses
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 6:
> 
> (1 comment)

https://gerrit.asterisk.org/c/asterisk/+/12824/6/res/res_pjsip_nat.c 
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/c/asterisk/+/12824/6/res/res_pjsip_nat.c@406 
PS6, Line 406: 		&& tdata->msg->type == PJSIP_REQUEST_MSG) {
> > Why this change? Wouldn't this break rewriting of Contact on 200 OK? […]
SIP 200 REGISTER has to contain original contact.

Without this if set external_signaling_address the Contact URI
will be external_signaling_address:port,
but has to be origin contact URI.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idc263ad2d2d7bd8faa047e5804d96a5fe1cd282e
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 15:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191206/eb54f29b/attachment-0001.html>