[Asterisk-code-review] pjsip/info_dtmf: Add pauses in scenarios to make tests more reliable (testsuite[13])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/testsuite/+/13304 )

Change subject: pjsip/info_dtmf:  Add pauses in scenarios to make tests more reliable
......................................................................

pjsip/info_dtmf:  Add pauses in scenarios to make tests more reliable

Added a 1000ms pause before sending the first digit and a 5000ms
pause after sending the last one.  The last one is most important
because sending SIP INFO packets in quick succession can cause
them to get deferred which would extend the time to process them all
to be after we sent a BYE.  In this case the test will fail because
all the DTMFEnd events wouldn't have arrived before the test ended.

Change-Id: Ie86fdceabf20bdec9fc1a38a79a3523ef778f8eb
---
M tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml
M tests/channels/pjsip/info_dtmf/sipp/dtmf.xml
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  Friendly Automation: Looks good to me, approved; Approved for Submit



diff --git a/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml b/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml
index ec64c0d..ad938f9 100644
--- a/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml
+++ b/tests/channels/pjsip/info_dtmf/sipp/dtmf-duration.xml
@@ -68,6 +68,8 @@
   <recv response="200" crlf="true">
   </recv>
 
+  <pause milliseconds="1000"/>
+
   <send retrans="500">
     <![CDATA[
       INFO sip:test2@[remote_ip]:[remote_port] SIP/2.0
@@ -383,7 +385,7 @@
   <recv response="200" crlf="true">
   </recv>
 
-  <pause/>
+  <pause milliseconds="5000"/>
 
   <send retrans="500">
     <![CDATA[
diff --git a/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml b/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml
index 59a6e85..f0a9aae 100644
--- a/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml
+++ b/tests/channels/pjsip/info_dtmf/sipp/dtmf.xml
@@ -47,6 +47,8 @@
     ]]>
   </send>
 
+  <pause milliseconds="1000"/>
+
   <send retrans="500">
     <![CDATA[
       INFO sip:test@[remote_ip]:[remote_port] SIP/2.0
@@ -367,7 +369,7 @@
   <recv response="200" crlf="true">
   </recv>
 
-  <pause/>
+  <pause milliseconds="5000"/>
 
   <send retrans="500">
     <![CDATA[

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13304
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: Ie86fdceabf20bdec9fc1a38a79a3523ef778f8eb
Gerrit-Change-Number: 13304
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191206/d96ef880/attachment.html>