[Asterisk-code-review] chan_sip: in case of tcp/tls, be less annoying about tx errors. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13366 )

Change subject: chan_sip:  in case of tcp/tls, be less annoying about tx errors.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13366/2/channels/chan_sip.c 
File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/13366/2/channels/chan_sip.c@2571 
PS2, Line 2571: 	if (tcptls_session->fd == -1){
Add space before curly


https://gerrit.asterisk.org/c/asterisk/+/13366/2/channels/chan_sip.c@2581 
PS2, Line 2581: 		ast_log(LOG_ERROR, "Memory allocation error trying to write packet to tcptls_session.");
You don't need to log memory allocation errors.  The Asterisk allocation routines always log allocation failures.  These specialized allocation errors do give more indication of who had the failure.  However, if you have an out of memory error then asterisk is likely going to get into an unstable state anyway so the extra info does not really help that much.


https://gerrit.asterisk.org/c/asterisk/+/13366/2/channels/chan_sip.c@30172 
PS2, Line 30172: if (res < -1)
               : 			return 0;
guidelines: Always use curly braces.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13366
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I46eb82924beeff9dfd86fa6c7eb87d2651b950f2
Gerrit-Change-Number: 13366
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191205/ad78b195/attachment-0001.html>