[Asterisk-code-review] res_pjsip_outbound_registration: add support for SRV failover (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Tue Dec 3 15:22:48 CST 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13228 )

Change subject: res_pjsip_outbound_registration: add support for SRV failover
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13228/1/res/res_pjsip_outbound_registration.c 
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/13228/1/res/res_pjsip_outbound_registration.c@913 
PS1, Line 913: 	if (response->code == 408 || response->code == 503) {
> Is a server not responding at all included in these codes?
I believe pjsip sets a request timeout of 408 if the server never responds.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13228
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8da7c300dd985ab7b10dbd5194aff2f737808561
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 21:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191203/434ec5f2/attachment-0001.html>


More information about the asterisk-code-review mailing list