[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 31: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/11579/31/apps/app_audiosocket.c 
File apps/app_audiosocket.c:

https://gerrit.asterisk.org/c/asterisk/+/11579/31/apps/app_audiosocket.c@165 
PS31, Line 165: 		ast_log(LOG_ERROR, "Channel is %s\n", chan ? "not up" : "missing");
a user doesn't know what "not up" generally means - they know what "not answered" means though


https://gerrit.asterisk.org/c/asterisk/+/11579/31/channels/chan_audiosocket.c 
File channels/chan_audiosocket.c:

https://gerrit.asterisk.org/c/asterisk/+/11579/31/channels/chan_audiosocket.c@284 
PS31, Line 284: 	//ast_format_cap_append(audiosocket_channel_tech.capabilities, ast_format_slin, 0);
This can be removed



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 31
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 15:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191203/60b4a6ca/attachment-0001.html>