[Asterisk-code-review] ARI: Ability to inhibit COLP frames when adding channels to a bridge (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13306 )

Change subject: ARI: Ability to inhibit COLP frames when adding channels to a bridge
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

This should also be added to the CHANGES file[1].

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

https://gerrit.asterisk.org/c/asterisk/+/13306/1/rest-api/api-docs/bridges.json 
File rest-api/api-docs/bridges.json:

https://gerrit.asterisk.org/c/asterisk/+/13306/1/rest-api/api-docs/bridges.json@196 
PS1, Line 196: 							"name": "inhibitCOLP",
             : 							"description": "Do not generate COLP frames when joining the bridge",
I don't think this should be exposed as "COLP" to outside consumers. I think it should be explicitly stated as inhibitConnectedLineUpdates, and the description should cover what exactly it means and what this prevents. In the case of "mute" and "DTMF" those are much more known, while connected line updates may not be.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13306
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib995d4f0c6106279aa448b34b042b68f0f2ca5dc
Gerrit-Change-Number: 13306
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 13:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191202/59a22de6/attachment.html>