[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 30: Code-Review-1

(2 comments)

This should also go in the CHANGES too.

https://gerrit.asterisk.org/c/asterisk/+/11579/30/apps/app_audiosocket.c 
File apps/app_audiosocket.c:

https://gerrit.asterisk.org/c/asterisk/+/11579/30/apps/app_audiosocket.c@164 
PS30, Line 164: 	if (!chan || ast_channel_state(chan) != AST_STATE_UP) {
I could see this confusing someone. If the channel isn't up other applications generally answer it. As it is now it would just stop in the dialplan and you wouldn't know why.


https://gerrit.asterisk.org/c/asterisk/+/11579/30/channels/chan_audiosocket.c 
File channels/chan_audiosocket.c:

https://gerrit.asterisk.org/c/asterisk/+/11579/30/channels/chan_audiosocket.c@148 
PS30, Line 148: 	struct ast_format *fmt = NULL;
This is leaking in this function. It doesn't appear to ever be unreffed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 30
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 12:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191202/375aacbf/attachment-0001.html>