[Asterisk-code-review] res_pjsip_endpoint_identifier_ip.c: Add port matching support (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13312 )

Change subject: res_pjsip_endpoint_identifier_ip.c: Add port matching support
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> It seems weird, as a user, for "match_port" to be separate and instead not part of the "match" line itself and only scoped to that.

I don’t disagree, but I couldn’t think of an elegant way to represent the port as part of the existing match syntax.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13312
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I256d5bd5d478b95f526e2f80ace31b690eebba92
Gerrit-Change-Number: 13312
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 12:06:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191202/5b201a92/attachment.html>