[Asterisk-code-review] ARI: External Media (...asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Aug 27 06:42:45 CDT 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12775 )

Change subject: ARI: External Media
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/12775/1/rest-api/api-docs/channels.json 
File rest-api/api-docs/channels.json:

https://gerrit.asterisk.org/#/c/12775/1/rest-api/api-docs/channels.json@1761 
PS1, Line 1761: 					"responseClass": "Channel",
Would it be better to encapsulate this in another, so that if we need to return additional information besides what is present on a channel we don't need a second interface that returns that class instead of Channel for backwards compatibility?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12775
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9618899198880b4c650354581b50c0401b58bc46
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 11:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190827/ab4c4c50/attachment.html>


More information about the asterisk-code-review mailing list