[Asterisk-code-review] chan_sip, chan_dahdi: Allow updating variable value. (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10930 )

Change subject: chan_sip, chan_dahdi: Allow updating variable value.
......................................................................


Patch Set 13:

I've updated this review to remove the changes to chan_iax2 because those seemed to be the most contentious part.

I've also changed the name of the function to ast_variable_upsert (it was ast_var_update and we already have an ast_variable_update). I'm not married to the name, so feel free to offer alternatives (ast_variable_update_or_append seemed to wordy to me, but I just work here).

Because the chan_iax2 changes have been removed this is a pure bug fix review and I will be cherry-picking to 13+.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 10930
Gerrit-PatchSet: 13
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 19:59:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190815/b86cfb02/attachment-0001.html>