[Asterisk-code-review] srtp: Fix possible race condition, and add NULL checks (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11698 )

Change subject: srtp: Fix possible race condition, and add NULL checks
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/11698/1/res/res_srtp.c 
File res/res_srtp.c:

https://gerrit.asterisk.org/#/c/11698/1/res/res_srtp.c@198 
PS1, Line 198: 		ast_log(LOG_ERROR, "Unable to allocate memory for srtp policies\n");
Does ao2_t_container_alloc_hash() not log an error if it fails?


https://gerrit.asterisk.org/#/c/11698/1/res/res_srtp.c@350 
PS1, Line 350: 		ast_log(LOG_ERROR, "SRTP unprotect %s - missing session\n",	rtcp ? "rtcp" : "rtp");
There's a tab before 'rtcp' instead of a space.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11698
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I240e11cbb1e9ea8083d59d50db069891228fe5cc
Gerrit-Change-Number: 11698
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 11:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190808/0801e337/attachment.html>