[Asterisk-code-review] res_pjsip: Channel variable SIPFROMDOMAIN (...asterisk[master])

[Stas Kobzar]

Stas Kobzar has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable SIPFROMDOMAIN
......................................................................


Patch Set 4:

(3 comments)

> Patch Set 4: Code-Review-1
> 
> (2 comments)
I am using separate branch for development and this are new changes in master branch.

https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c@1504 
PS2, Line 1504:   
> Red blob
Done


https://gerrit.asterisk.org/#/c/11651/4/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/11651/4/res/res_pjsip_session.c@a3446 
PS4, Line 3446: 
> Did you intend to remove this? If so, why?
No, I did not change it. This is just the difference with my branch and master branch.


https://gerrit.asterisk.org/#/c/11651/4/res/res_pjsip_session.c@a3470 
PS4, Line 3470: 
> Did you intend to remove this? If so, why?
No, I did not change it. This is just the difference with my branch and master branch.
This will not impact master when I do cherry-pick



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 4
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Stas Kobzar <stas at modulis.ca>
Gerrit-Comment-Date: Thu, 01 Aug 2019 19:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190801/d8d59418/attachment.html>