[Asterisk-code-review] res_pjsip: Channel variable PJSIP_FROM_DOMAIN (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable PJSIP_FROM_DOMAIN
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > (3 comments)
> > 
> > See previous comments, probably best to use SIPFROMDOMAIN for consistency with other places in PJSIP land.
> 
> I understood it as the name PJSIP_FROM_DOMAIN was more suitable. No?
> >> we should at least make it a variable name that we can live with long term, like PJSIP_FROM_DOMAIN.

At this point I don't think it matters much. Either is fine.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 2
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Stas Kobzar <stas at modulis.ca>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:23:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190801/918d634e/attachment-0001.html>