[Asterisk-code-review] res_pjsip: Channel variable PJSIP_FROM_DOMAIN (...asterisk[master])

[Stas Kobzar]

Stas Kobzar has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable PJSIP_FROM_DOMAIN
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> I'm not a huge fan of using "magic variables" to change behavior in new code. Our goal with chan_pjsip is feature parity with chan_sip, not necessarily compatibility. If we _were_ to allow a channel variable to influence behavior, we should at least make it a variable name that we can live with long term, like PJSIP_FROM_DOMAIN.
> 
> I'm not that passionate about it, so I won't prevent the inclusion. Just some food for thought.


Ok, thanks. I have updated the commit with variable name PJSIP_FROM_DOMAIN and using chan lock.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 2
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Stas Kobzar <stas at modulis.ca>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:14:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190801/45d8895c/attachment.html>