[Asterisk-code-review] In app_control_dial hangup channel on failure (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11314 )

Change subject: In app_control_dial hangup channel on failure
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11314/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11314/1//COMMIT_MSG@7 
PS1, Line 7: In app_control_dial hangup channel on failure
Please see the wiki page[1] for constructing commit messages. They're important to ensure that if someone needs to figure out why something was done they have the information they need.

[1] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/#/c/11314/1/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/11314/1/res/stasis/control.c@1652 
PS1, Line 1652:                 ast_softhangup_nolock(chan, hangup_flag);
I think a comment is needed here to explain why this is done and what it causes to happen.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11314
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I15eee0b2701b69403b249d466024db4c962b6f10
Gerrit-Change-Number: 11314
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 10:20:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190430/0c986b5e/attachment.html>