[Asterisk-code-review] digium_git.py: Verify All Tags Are Fetched (...repotools[master])

George Joseph asteriskteam at digium.com
Fri Apr 26 13:23:29 CDT 2019


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/repotools/+/11307 )

Change subject: digium_git.py: Verify All Tags Are Fetched
......................................................................

digium_git.py: Verify All Tags Are Fetched

When creating a release, on running the mkrelease.py script, there
is been reporting that not all corresponding tags from previous
release are copied to the new one. Not able to replicate the issue
but adding a "git fetch --tags" is a safe step.

Change-Id: I970b2390ef339a9d697a3a8bcdf948edf1a06760
---
M digium_git.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/digium_git.py b/digium_git.py
index 6853647..3ac01ef 100644
--- a/digium_git.py
+++ b/digium_git.py
@@ -218,7 +218,7 @@
             origin = self.repo.remotes.origin
 
         origin.fetch(progress=self.progress)
-        origin.fetch(progress=self.progress)
+        origin.fetch("--tags")
 
     @property
     def progress(self):

-- 
To view, visit https://gerrit.asterisk.org/c/repotools/+/11307
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Change-Id: I970b2390ef339a9d697a3a8bcdf948edf1a06760
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190426/91d1f385/attachment.html>


More information about the asterisk-code-review mailing list