[Asterisk-code-review] stasis: Fix crash at shutdown. (...asterisk[13])

Benjamin Keith Ford asteriskteam at digium.com
Wed Apr 24 08:47:25 CDT 2019


Hello Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11304

to look at the new patch set (#3).

Change subject: stasis: Fix crash at shutdown.
......................................................................

stasis: Fix crash at shutdown.

When compiling in dev mode, stasis statistics are enabled and can cause
a crash at shutdown due to the following:
- Containers are freed
- Topics and subscriptions remain
- When those topics and subscriptions are deallocated, they go to do
  things with the container

This changes the containers to global ao2 objects, and whenever needed
in the code, a reference must be obtained and checked before any
operations can be done.

ASTERISK-28353 #close

Change-Id: Ie7d5e907fcfcb4d65bd36d5e4eb923126fde8d33
---
M main/stasis.c
1 file changed, 111 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/04/11304/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11304
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ie7d5e907fcfcb4d65bd36d5e4eb923126fde8d33
Gerrit-Change-Number: 11304
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190424/81cebdc2/attachment.html>


More information about the asterisk-code-review mailing list