[Asterisk-code-review] stasis: Re-set the PBX pointer before attempting to join the dial bridge (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11255 )

Change subject: stasis: Re-set the PBX pointer before attempting to join the dial bridge
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > (1 comment)
> 
> Incoming call when not answered in Stasis and put in bridge seems to be having a PBX attached to it

I don't think the intention of the code was for those types of channels to be placed back into the dial bridge in this case. They aren't outgoing channels. I wonder if the code should have a check that if a PBX exists the channel should not be placed back into the dialing bridge, and what the implications of that are.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11255
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I788151b7045791d1d5d35453875027a60e6d527a
Gerrit-Change-Number: 11255
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 09:37:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190423/e4529dc6/attachment.html>