[Asterisk-code-review] stasis: Cancel the callback when joining the bridge fails (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11254 )

Change subject: stasis: Cancel the callback when joining the bridge fails
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11254/1/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/11254/1/res/stasis/control.c@1068 
PS1, Line 1068: 		ast_bridge_discard_after_callback(chan, AST_BRIDGE_AFTER_CB_REASON_IMPART_FAILED);
I don't think this is the correct place for this. Relying on the caller of ast_bridge_impart to do the right thing in this case doesn't seem correct to me. I think ast_bridge_impart should invoke the callback on the failure cases, and the documentation should be updated to make this clear.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11254
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib4e8f70d7a21bd54afe3cb51cc6717ef7c355496
Gerrit-Change-Number: 11254
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 22 Apr 2019 15:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190422/d318d7c7/attachment.html>