[Asterisk-code-review] res/res_pjsip_sip_debug: added sip message event notifier (...asterisk[master])

sungtae kim asteriskteam at digium.com
Thu Apr 18 14:44:16 CDT 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10715 )

Change subject: res/res_pjsip_sip_debug: added sip message event notifier
......................................................................


Patch Set 8:

> Patch Set 8:
> 
> Sung, although I thought it looked interested, it looks like there's not enough solid buy-in from other members of the -dev team to merge this.  I think for now, abandoning this review and maintaining it out of tree might be the suggested way forward.

Hi mattf,

Thank you for your kind reply. I totally respect team's decision. I was seeing how the process went and impressed by how many people tried to understand this humble code. :)

I was thinking the same thing. :)

I'm just want to say thank you for all team's effort.

Next time, I will bring more nice code. :)

I'll abandon this code, but please close the related ticket.

Thank you.

Kind regards,
Sungtae.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10715
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1dedcc678265ebb74d35e7a2f58bc4b5084bcfe1
Gerrit-Change-Number: 10715
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: mattf <creslin at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 19:44:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190418/d32faccb/attachment.html>


More information about the asterisk-code-review mailing list