[Asterisk-code-review] res/ari/resource_channels.c: Added detail hangup reason (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11287 )

Change subject: res/ari/resource_channels.c: Added detail hangup reason
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11287/1/rest-api/api-docs/channels.json 
File rest-api/api-docs/channels.json:

https://gerrit.asterisk.org/#/c/11287/1/rest-api/api-docs/channels.json@429 
PS1, Line 429: 									"not_defined",
I don't think many of these should be exposed as named reasons. The previous list was actually kind of chosen on purpose to be approachable for those who are not familiar with telephony in great detail. These added ones will confuse people, and generally would likely never be used.

With the added ability to specify a response code they also don't need to be here - since power users can use that mechanism instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11287
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1cf1d991ffd759d0591b347445a55f416ddc3ff2
Gerrit-Change-Number: 11287
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 11:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190418/dd5769ad/attachment.html>