[Asterisk-code-review] pbx_dundi: added IPv4/IPv6 dual bind support to DUNDi (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10860 )

Change subject: pbx_dundi: added IPv4/IPv6 dual bind support to DUNDi
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 2: Code-Review-1
> > 
> > (4 comments)
> > 
> > The DUNDi documentation also needs to be updated with this new functionality.
> 
> Apologies for the late response. I have looked and updated based on your review. I have a few comments in regards to your comments.
> 
> Line 4976: This isn't a particularly good name for this. This is really a bind address for IPv6, while bindaddr is for IPv4.
> 
> Response: bindaddr/bindaddr2 are not restricted to a specific protocol. ie, you could define bindaddr to an IPv6 address and bindaddr2 to an IPv4 address and vice versa. This also allows you to only bind to one address and that be an IPv6 address. If bindaddr inst defined then it is bound to IPv4 on all addresses and bindaddr2 needs to be IPv6 as the bindaddr/2 need to be different protocols. Therefore I don't think this has been named inappropriately. 
> 
> Line 5195: This should be more explicit about what is needed. You have explicit logic that expects the second one to be IPv6.
> 
> Response: See above comment, but again I dont believe there is explicit logic. I have tested the first address being IPv6 and the second address being IPv4. Could you point me to where the logic is restricting?

Looking at the code again I believe you are correct and I was confused originally. It's hard to follow at times.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10860
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5d6e6b52dbe51415046bb3953fd16f5b421bc2e1
Gerrit-Change-Number: 10860
Gerrit-PatchSet: 3
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: mattf <creslin at digium.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 09:17:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190418/18524530/attachment.html>