[Asterisk-code-review] app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11207 )

Change subject: app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11207/5/apps/app_dial.c 
File apps/app_dial.c:

https://gerrit.asterisk.org/#/c/11207/5/apps/app_dial.c@1501 
PS5, Line 1501: 						snprintf(buf, sizeof(buf), "%d.%03d", (int)(diff/1000), (int)(diff%1000));
              : 							pbx_builtin_setvar_helper(in, "RINGTIME_MS", buf);
> Are we sure this is how we want to format this? >From the
 > documentation I would expect this to be 10000 for 10 seconds, not
 > 10.000.

Uhm, yeah.  That's an issue.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11207
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If95f1a7d8c4acbac740037de0c6e3109ff6620b1
Gerrit-Change-Number: 11207
Gerrit-PatchSet: 5
Gerrit-Owner: Antoni Goldstein <action at gdevel.com>
Gerrit-Reviewer: Antoni Goldstein <action at gdevel.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 16:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190417/53eb97b4/attachment-0001.html>