[Asterisk-code-review] main/stasis.c: Fixed duplicated forwarding (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11201 )

Change subject: main/stasis.c: Fixed duplicated forwarding
......................................................................


Patch Set 4:

(3 comments)

> Patch Set 3: Code-Review-1
> 
> (4 comments)

Hi Joshua,

Thank you for your kind review. Fixed it as your comments. :)

https://gerrit.asterisk.org/#/c/11201/3//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11201/3//COMMIT_MSG@7 
PS3, Line 7: Fixed duplicated subscription adding
> This should have res_stasis: at the front, and also better describe the new change (regarding forwar […]
Right, forgot to add that.


https://gerrit.asterisk.org/#/c/11201/3/include/asterisk/stasis.h 
File include/asterisk/stasis.h:

https://gerrit.asterisk.org/#/c/11201/3/include/asterisk/stasis.h@137 
PS3, Line 137:  * It is safe to duplicate subscribing. Once the subscriber subscribes given topic
             :  * already, it doesn't increase subscriber reference count. So, don't have to
             :  * unsubscribe many times for in case of duplicated subscribing.
> I don't think this should be changed due to the reason I gave regarding forwarding.
Right, it's not the subscriber.

Moved it to the forwarding description.


https://gerrit.asterisk.org/#/c/11201/3/main/stasis.c 
File main/stasis.c:

https://gerrit.asterisk.org/#/c/11201/3/main/stasis.c@1050 
PS3, Line 1050: static int topic_add_subscription(struct stasis_topic *topic, struct stasis_subscription *sub)
> I don't think the changes in here are needed any longer due to the reason I previously gave, as forw […]
Right, removed it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11201
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I00bd627e4cc21aba0535d2695460a04f06f6e699
Gerrit-Change-Number: 11201
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190410/c45e2ee3/attachment.html>