[Asterisk-code-review] build: Improve handling of CHANGES and UPGRADE.txt for releases. (...repotools[master])

Kevin Harwell asteriskteam at digium.com
Wed Apr 10 12:17:12 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/repotools/+/10941 )

Change subject: build: Improve handling of CHANGES and UPGRADE.txt for releases.
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/10941/8/staging_changes.py 
File staging_changes.py:

https://gerrit.asterisk.org/#/c/10941/8/staging_changes.py@175 
PS8, Line 175: .lstrip().rstrip()
can just use .strip() here if you want.



-- 
To view, visit https://gerrit.asterisk.org/c/repotools/+/10941
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Change-Id: I6dc084afedaeecaf36aaec66c3cf6a5a8ed4ef3c
Gerrit-Change-Number: 10941
Gerrit-PatchSet: 8
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 17:17:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190410/fbbdc98d/attachment.html>


More information about the asterisk-code-review mailing list