[Asterisk-code-review] core/buildsystem: check the actual compiler being version (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11238 )

Change subject: core/buildsystem: check the actual compiler being version
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11238/1/Makefile.rules 
File Makefile.rules:

https://gerrit.asterisk.org/#/c/11238/1/Makefile.rules@71 
PS1, Line 71: gcc
I think this will have to be $(notdir $(CC)).  If CC=clang for instance, a grep ^gcc will cause a bash error.  A bash error will also occur if you just use $(CC) here and CC=/usr/bin/gcc or CC=/usr/bin/clang so the "notdir" is needed to ensure we grep for just "clang" or "gcc".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Icaacf6d93686ad21076878aa1504a23b4fc9d0f4
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 1
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 09 Apr 2019 13:21:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190409/10a244b9/attachment.html>