[Asterisk-code-review] CI: Add --no-dev-mode option to buildAsterisk.sh (...asterisk[16])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11226 )

Change subject: CI:  Add --no-dev-mode option to buildAsterisk.sh
......................................................................

CI:  Add --no-dev-mode option to buildAsterisk.sh

The new option disables dev mode, TEST_FRAMEWORK and
MALLOC_DEBUG making the build more production-like.

Change-Id: Ieb72497d4d91d5416684aaed702cc3f532099738
---
M tests/CI/buildAsterisk.sh
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/tests/CI/buildAsterisk.sh b/tests/CI/buildAsterisk.sh
index 6877eaf..064cdbc 100755
--- a/tests/CI/buildAsterisk.sh
+++ b/tests/CI/buildAsterisk.sh
@@ -8,6 +8,7 @@
 NO_MENUSELECT=0
 NO_MAKE=0
 NO_ALEMBIC=0
+NO_DEV_MODE=0
 source $CIDIR/ci.functions
 
 set -e
@@ -93,7 +94,9 @@
 common_config_args="--prefix=/usr ${_libdir:+--libdir=${_libdir}} --sysconfdir=/etc --with-pjproject-bundled"
 $PKGCONFIG 'jansson >= 2.11' || common_config_args+=" --with-jansson-bundled"
 common_config_args+=" ${CACHE_DIR:+--with-sounds-cache=${CACHE_DIR}/sounds --with-externals-cache=${CACHE_DIR}/externals}"
-common_config_args+=" --enable-dev-mode"
+if [ $NO_DEV_MODE -eq 0 ] ; then
+	common_config_args+=" --enable-dev-mode"
+fi
 if [ $COVERAGE -eq 1 ] ; then
 	common_config_args+=" --enable-coverage"
 fi
@@ -110,7 +113,10 @@
 if [ $NO_MENUSELECT -eq 0 ] ; then
 	runner ${MAKE} menuselect.makeopts
 
-	runner menuselect/menuselect `gen_mods enable DONT_OPTIMIZE BETTER_BACKTRACES MALLOC_DEBUG DO_CRASH TEST_FRAMEWORK` menuselect.makeopts
+	runner menuselect/menuselect `gen_mods enable DONT_OPTIMIZE BETTER_BACKTRACES` menuselect.makeopts
+	if [ $NO_DEV_MODE -eq 0 ] ; then
+		runner menuselect/menuselect `gen_mods enable MALLOC_DEBUG DO_CRASH TEST_FRAMEWORK` menuselect.makeopts
+	fi
 	runner menuselect/menuselect `gen_mods disable COMPILE_DOUBLE BUILD_NATIVE` menuselect.makeopts
 	if [ $REF_DEBUG -eq 1 ] ; then
 		runner menuselect/menuselect --enable REF_DEBUG menuselect.makeopts
@@ -119,6 +125,10 @@
 	cat_enables="MENUSELECT_BRIDGES MENUSELECT_CEL MENUSELECT_CDR"
 	cat_enables+=" MENUSELECT_CHANNELS MENUSELECT_CODECS MENUSELECT_FORMATS MENUSELECT_FUNCS"
 	cat_enables+=" MENUSELECT_PBX MENUSELECT_RES MENUSELECT_UTILS MENUSELECT_TESTS"
+
+	if [ $NO_DEV_MODE -eq 0 ] ; then
+		cat_enables+=" MENUSELECT_TESTS"
+	fi
 	runner menuselect/menuselect `gen_cats enable $cat_enables` menuselect.makeopts
 
 	mod_disables="res_digium_phone chan_vpb"
@@ -208,5 +218,3 @@
 if [ -f "doc/core-en_US.xml" ] ; then
 	runner ${MAKE} validate-docs || ${MAKE} NOISY_BUILD=yes validate-docs
 fi
-
-

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieb72497d4d91d5416684aaed702cc3f532099738
Gerrit-Change-Number: 11226
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190408/59e72d0f/attachment.html>