[Asterisk-code-review] DTMF Mode auto_info fallback lead to both inband and info (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11224 )

Change subject: DTMF Mode auto_info fallback lead to both inband and info
......................................................................


Patch Set 1:

> Actually we want to return(0) same as AST_SIP_DTMF_INFO. In that case, we fallback to info since destination has no rfc capability and return res(0) from that method not to do inband in that case.

That's fine. I am not commenting on the logical correctness of the patch, just that you should explicitly return 0 instead of returning 'res'. It's more clear considering that is the only possible return value here.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11224
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a
Gerrit-Change-Number: 11224
Gerrit-PatchSet: 1
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 16:13:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190403/075e53e8/attachment-0001.html>