[Asterisk-code-review] DTMF Mode auto_info fallback lead to both inband and info (...asterisk[13])

Salah Ahmed asteriskteam at digium.com
Wed Apr 3 10:57:04 CDT 2019


Salah Ahmed has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/11224


Change subject: DTMF Mode auto_info fallback lead to both inband and info
......................................................................

DTMF Mode auto_info fallback lead to both inband and info

while endpoint's dtmf_mode configured as "auto_info". If this
mode fallback to info, then asterisk produce inband dtmf tone
along with info message.

ASTERISK-28371
Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a
---
M channels/chan_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/24/11224/1

diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 36cc0ad..015734c 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1758,7 +1758,7 @@
 		break;
 	case AST_SIP_DTMF_AUTO_INFO:
 		if (!media || !media->rtp || (ast_rtp_instance_dtmf_mode_get(media->rtp) == AST_RTP_DTMF_MODE_NONE)) {
-			return -1;
+			return res;
 		}
 		ast_rtp_instance_dtmf_begin(media->rtp, digit);
 		break;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11224
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a
Gerrit-Change-Number: 11224
Gerrit-PatchSet: 1
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190403/d917ef0a/attachment.html>


More information about the asterisk-code-review mailing list