[Asterisk-code-review] stasis.c: Added topic_all container (...asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11013 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.asterisk.org/#/c/11013/10/main/stasis.c 
File main/stasis.c:

https://gerrit.asterisk.org/#/c/11013/10/main/stasis.c@409 
PS10, Line 409: static void proxy_dtor(void *weakproxy, void *data)
It looks like "data" is not needed here


https://gerrit.asterisk.org/#/c/11013/10/main/stasis.c@498 
PS10, Line 498: 		ao2_ref(topic_tmp, -1);
Does "topic_tmp" need to be unref'd here? If this function fails, it looks like it unref's the topic when it returns to "stasis_topic_create_with_detail"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 10
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 11:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190403/f0f2797f/attachment.html>