[Asterisk-code-review] app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11207 )

Change subject: app_dial.c: RINGTIME, PROGRESSTIME and ms resolution dial timings
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

These changes should also be documented in the CHANGES file.

https://gerrit.asterisk.org/#/c/11207/3/apps/app_dial.c 
File apps/app_dial.c:

https://gerrit.asterisk.org/#/c/11207/3/apps/app_dial.c@1192 
PS3, Line 1192: 
At the start of dial_exec_full the variables should be set to empty like the other ones, to ensure old data doesn't mix with new data.


https://gerrit.asterisk.org/#/c/11207/3/apps/app_dial.c@1482 
PS3, Line 1482: 							pbx_builtin_setvar_helper(in, "RINGTIME", buf);
All of the newly added variables need to be documented in the XML at the top of this file, where ANSWEREDTIME and the rest are.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11207
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If95f1a7d8c4acbac740037de0c6e3109ff6620b1
Gerrit-Change-Number: 11207
Gerrit-PatchSet: 3
Gerrit-Owner: Antoni Goldstein <action at gdevel.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 13:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190402/f36fca46/attachment.html>