[Asterisk-code-review] jira-release-update & digium_jira: bad jira object reference (...repotools[master])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/repotools/+/11213 )

Change subject: jira-release-update & digium_jira: bad jira object reference
......................................................................

jira-release-update & digium_jira: bad jira object reference

The jira-release-update script was unable to retrieve the jira issue due to it
attempting to use an unitialized object.

Patched to make it use an initialized jira object.

Change-Id: Id7ae51b7b3fbd124588d0beab560bebf43644aa3
---
M digium_jira.py
M jira-release-update.py
2 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/digium_jira.py b/digium_jira.py
index b7d26f8..31aa301 100644
--- a/digium_jira.py
+++ b/digium_jira.py
@@ -67,6 +67,14 @@
         self._jira = jira or get_jira_client()
         self._project = project
 
+    def issue(self, issue_id):
+        """Retrieve the jira object for the given id
+
+        Keyword Arguments:
+        issue_id - The issue id
+        """
+        return self._jira.issue(issue_id)
+
 
 class DigiumJiraVersion(DigiumJira):
 
diff --git a/jira-release-update.py b/jira-release-update.py
index b980638..1bd5cad 100755
--- a/jira-release-update.py
+++ b/jira-release-update.py
@@ -56,7 +56,7 @@
         for issue_obj in issues:
             issue_id = issue_obj.get('id')
             try:
-                issue = jira.issue(issue_id)
+                issue = djv.issue(issue_id)
             except Exception:
                 print "Could not get issue {0}".format(issue_id)
                 continue

-- 
To view, visit https://gerrit.asterisk.org/c/repotools/+/11213
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Change-Id: Id7ae51b7b3fbd124588d0beab560bebf43644aa3
Gerrit-Change-Number: 11213
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190402/24890a9c/attachment.html>