[Asterisk-code-review] build: Revise CHANGES and UPGRADE.txt handling. (...asterisk[master])

Benjamin Keith Ford asteriskteam at digium.com
Mon Apr 1 15:53:40 CDT 2019


Hello Kevin Harwell, Friendly Automation, George Joseph, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/10945

to look at the new patch set (#3).

Change subject: build: Revise CHANGES and UPGRADE.txt handling.
......................................................................

build: Revise CHANGES and UPGRADE.txt handling.

This changes the way that we handle adding changes to CHANGES and
UPGRADE.txt. The reason for this is because whenever someone needed to
make a change to one of these files and someone else had already done
so, you would run into merge conflicts. With this new setup, there will
never be merge conflicts since all changes will be documented in the
doc/<file>-staging directory. The release script is now responsible for
merging all of these changes into the appropriate files.

There is a special format that these files have to follow in order to be
parsed. The files do not need to have a meaningful name, but it is
strongly recommended. For example, if you made a change to pjsip, you
may have something like this "res_pjsip_relative_title", where
"relative_title" is something more descriptive than that. Inside each
file, you will need a subject line for your change, followed by a
description. There can be multiple subject lines. The file may look
something like this:

   Subject: res_pjsip

   A description that explains the changes made and why. The release
   script will handle the bulleting and section separators!

   You can still separate with new lines within your
   description.

   Subject: res_pjsip

   You can have more than one subject!

   Subject: Core
   Master-Only: true

   The subjects don't have to be the same. The header "Master-Only"
   should ONLY go on reviews that are in only the master branch, and the
   value will ALWAYS be true.

The headers ("Subject" and "Master-Only") are case sensative, but the
value for "Master-Only" ("true" or "True") is not.

For more information, check out the wiki page:
https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

ASTERISK-28111 #close

Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47
---
M CHANGES
D UPGRADE-1.2.txt
D UPGRADE-1.4.txt
D UPGRADE-1.6.txt
D UPGRADE-1.8.txt
D UPGRADE-10.txt
D UPGRADE-11.txt
D UPGRADE-12.txt
D UPGRADE-13.txt
D UPGRADE-14.txt
D UPGRADE-15.txt
D UPGRADE-16.txt
M UPGRADE.txt
A doc/CHANGES-staging/bridging_stasis_cache.txt
A doc/CHANGES-staging/chan_sip_deprecated.txt
A doc/CHANGES-staging/channels_stasis_cache.txt
A doc/UPGRADE-staging/applications_jabberstatus.txt
A doc/UPGRADE-staging/bridging_stasis_cache.txt
A doc/UPGRADE-staging/chan_sip_deprecated.txt
A doc/UPGRADE-staging/channels_stasis_cache.txt
A doc/UPGRADE-staging/func_callerid_callerpres.txt
A doc/UPGRADE-staging/res_parking_parkingslot.txt
A doc/UPGRADE-staging/res_xmpp_jabberstatus.txt
23 files changed, 2,759 insertions(+), 2,986 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/45/10945/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190401/4744ec65/attachment.html>


More information about the asterisk-code-review mailing list