[Asterisk-code-review] lock: Improve performance of DEBUG THREADS. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10293 )

Change subject: lock: Improve performance of DEBUG_THREADS.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

I missed this the first time around.

https://gerrit.asterisk.org/#/c/10293/3/main/lock.c
File main/lock.c:

https://gerrit.asterisk.org/#/c/10293/3/main/lock.c@171
PS3, Line 171: 	int canlog = lt && strcmp(filename, "logger.c");
For this function and the rwlock destroy you need to continue using t->flags.tracking instead of the lt variable.  __ast_mutex_logger() uses canlog and that is checked regardless of the lt state.  If the tracker hasn't been setup, we won't set it up now and thus we won't log on errors.

Probably should use t->flags.tracking for all the canlog variables in all the other functions for completeness.


https://gerrit.asterisk.org/#/c/10293/3/main/lock.c@696
PS3, Line 696: 	int canlog = lt && strcmp(filename, "logger.c");
same about t->flags.tracking



-- 
To view, visit https://gerrit.asterisk.org/10293
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd650908901843e9fff47ef1c539f0e1b8cb13b
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 18:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180928/d6c00727/attachment.html>