[Asterisk-code-review] core: New variables CONNECTED LINE ORIGINAL * for intercepti... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10299 )

Change subject: core: New variables CONNECTED_LINE_ORIGINAL_* for interception routine
......................................................................


Patch Set 1: Code-Review-2

This patch is not necessary.

When you get a connected line update, the connected line information is already set to the new connected party (Bob) because you are no longer connected to the old party (Alice).  There is no relationship between the old and the new information because Bob is not Alice.  Thus in the normal case this patch wastes resources setting up channel variables and allocating memory that is not needed.

The only reason to revert the connected line information is if you wanted it to stay constant.  There are already several ways to get the constant information to reset the connected line information.  These ways do not require any changes to Asterisk and incur the storage overhead only when this behavior is needed.  I already provided example dialplan in this other review https://gerrit.asterisk.org/#/c/asterisk/+/10286/ to do just that.


-- 
To view, visit https://gerrit.asterisk.org/10299
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie39f7a3402101333531884873cb353c73cd5334d
Gerrit-Change-Number: 10299
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:54:19 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180928/e0fa2859/attachment.html>