[Asterisk-code-review] lock: Improve performance of DEBUG THREADS. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10293 )

Change subject: lock: Improve performance of DEBUG_THREADS.
......................................................................


Patch Set 2:

(1 comment)

I'm working on your other comments but I'd rather not replace calls to __ast_mutex_logger in this patch.  From what I can tell all instances of 'canlog' are used.

https://gerrit.asterisk.org/#/c/10293/2/main/lock.c
File main/lock.c:

https://gerrit.asterisk.org/#/c/10293/2/main/lock.c@689
PS2, Line 689: 	int canlog = lt && strcmp(filename, "logger.c");
> canlog not used
It's used by __ast_mutex_logger.. I know I don't like that either.  I could create an ast_mutex_logger macro which accepts canlog as the first argument that way canlog doesn't appear to be unused.



-- 
To view, visit https://gerrit.asterisk.org/10293
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd650908901843e9fff47ef1c539f0e1b8cb13b
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 17:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180928/412a836f/attachment.html>