[Asterisk-code-review] core/briding: correct crash case when bridge relay an empty ... (asterisk[13])

Corey Farrell asteriskteam at digium.com
Fri Sep 28 07:42:16 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10269 )

Change subject: core/briding: correct crash case when bridge relay an empty text frame
......................................................................


Patch Set 1: Code-Review-1

Per my comment on JIRA I don't think this is the correct solution.  It would be better to fix ast_frdup so that dataptr is never invalid for AST_TEXT_FRAME.  Otherwise this problem will resurface in many other places where dataptr is used.


-- 
To view, visit https://gerrit.asterisk.org/10269
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib882dd028598f13c4c233edbfdd7e54ad44a68e9
Gerrit-Change-Number: 10269
Gerrit-PatchSet: 1
Gerrit-Owner: Emmanuel BUU <emmanuel.buu at ives.fr>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 12:42:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180928/a91b3f57/attachment.html>


More information about the asterisk-code-review mailing list