[Asterisk-code-review] res pjsip: improve realtime performance on CLI 'pjsip show c... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10270 )

Change subject: res_pjsip: improve realtime performance on CLI 'pjsip show contacts'
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c
File res/res_pjsip/location.c:

https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@a1021
PS1, Line 1021: 
This function appears to no longer be used, so can be removed as well. Same for the "cli_contact_populate_container" callback.


https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1027
PS1, Line 1027: 		ast_free(wrapper->contact_id);
This should be removed. The contact_id's memory is free'd in the wrapper's destructor.


https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1031
PS1, Line 1031: 	wrapper->contact = contact;
              : 	ao2_bump(wrapper->contact);
This can be combined into a single statement if you want:

wrapper->contact = ao2_bump(contact)


https://gerrit.asterisk.org/#/c/10270/1/res/res_pjsip/location.c@1036
PS1, Line 1036:         return 0;
Use tabs here instead of spaces for indention.



-- 
To view, visit https://gerrit.asterisk.org/10270
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0ad65d14952a02fb213273a90f3f680a8149618
Gerrit-Change-Number: 10270
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 16:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180927/21d97a87/attachment.html>