[Asterisk-code-review] res rtp asterisk: Raise event when RTP port is allocated (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10259 )

Change subject: res_rtp_asterisk: Raise event when RTP port is allocated
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10259/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/10259/1/res/res_rtp_asterisk.c@3495
PS1, Line 3495: 			ast_test_suite_event_notify("RTP_PORT_ALLOCATED", "Port: %d", x);
Should this also pass the remote address, so you know which endpoint this will match to? For instance what if you have multiple endpoints for setting up media? How will the test match the endpoint to the port (if it needs to)?



-- 
To view, visit https://gerrit.asterisk.org/10259
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91bd45782e84284e01c89acf4b2da352e14ae044
Gerrit-Change-Number: 10259
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 14:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180926/8684e4fb/attachment.html>