[Asterisk-code-review] chan sip: SipNotify on Chan Sip vi AMI behave different to CLI (asterisk[13])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10176 )

Change subject: chan_sip: SipNotify on Chan_Sip vi AMI behave different to CLI
......................................................................

chan_sip: SipNotify on Chan_Sip vi AMI behave different to CLI

With tls and udp enabled asterisk generates a warning about sending
message via udp instead of tls.
sip notify command via cli works as expected and without warning.

asterisk has to set the connection information accordingly to connection
and not on presumption

ASTERISK-28057 #close

Change-Id: Ib43315aba1f2c14ba077b52d8c5b00be0006656e
---
M channels/chan_sip.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve; Verified
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index ebfcfeb..34299a8 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -15572,7 +15572,7 @@
 			return 0;
 		}
 
-		if (create_addr(p, channame, NULL, 0)) {
+		if (create_addr(p, channame, NULL, 1)) {
 			/* Maybe they're not registered, etc. */
 			dialog_unlink_all(p);
 			dialog_unref(p, "unref dialog inside for loop" );

-- 
To view, visit https://gerrit.asterisk.org/10176
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib43315aba1f2c14ba077b52d8c5b00be0006656e
Gerrit-Change-Number: 10176
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Katzmann <peter.katzmann at edag.de>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180926/4fc853a8/attachment-0001.html>