[Asterisk-code-review] res rtp asterisk.c: Add "seqno" strictrtp option (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10246 )

Change subject: res_rtp_asterisk.c: Add "seqno" strictrtp option
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10246/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/10246/2/res/res_rtp_asterisk.c@5536
PS2, Line 5536: 		if (strict_rtp_test_event) {
              : 			ast_test_suite_event_notify("STRICT_RTP_CLOSED", "Source: %s",
              : 				ast_sockaddr_stringify(&addr));
              : 			strict_rtp_test_event = 0; /* Only run this event once to prevent possible spam */
              : 		}
> If we do that, we can just do ast_test_suite_event_notify since it
 > already checks for TEST_FRAMEWORK in test.h and defines the
 > function as an empty one if TEST_FRAMEWORK is not present. However,
 > this means this event will get spammed now every time a packet
 > comes in from a source we didn't learn. Is that ok, or do you have
 > another suggestion on how to resolve that?

Maybe I'm missing something.  You still want to keep the existing "if" that tests strict_rtp_test_event. Just surround the whole "if" block with the #ifdef so that when TEST_FRAMEWORK isn't defined we don't even test the flag any more.



-- 
To view, visit https://gerrit.asterisk.org/10246
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a42b8d193673899c8fc22fe7f98ea87df89be71
Gerrit-Change-Number: 10246
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Wed, 26 Sep 2018 13:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180926/b949386e/attachment.html>