[Asterisk-code-review] res pjsip sdp rtp: Extra fingerprint attribute in SDP (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10245 )

Change subject: res_pjsip_sdp_rtp: Extra fingerprint attribute in SDP
......................................................................


Patch Set 1: Code-Review-1

As I expressed on the issue I don't think partially supporting optimistic for DTLS should be merged in. While it does work for incoming use cases it doesn't for outgoing, so anyone wishing to use it would get confused.

I think actually the configuration should be considered invalid if it is dtls and optimistic.


-- 
To view, visit https://gerrit.asterisk.org/10245
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I559ea4253f43ab9fc99dc1511b170f02edd4df6c
Gerrit-Change-Number: 10245
Gerrit-PatchSet: 1
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 10:27:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180924/06d7af00/attachment.html>