[Asterisk-code-review] app queue: Fix Attended transfer hangup with removing pendin... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10048 )

Change subject: app_queue: Fix Attended transfer hangup with removing pending member.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

The solution looks like the best you can do with the situation and the way the code is structured.  There are a couple more exit points that have the same issue that I have pointed out.

https://gerrit.asterisk.org/#/c/10048/2/apps/app_queue.c
File apps/app_queue.c:

https://gerrit.asterisk.org/#/c/10048/2/apps/app_queue.c@6774
PS2, Line 6774: 				ast_autoservice_chan_hangup_peer(qe->chan, peer);
              : 				ao2_ref(member, -1);
Need to put the following between these two lines here for the same reason: We have not bridged the caller and peer yet.

pending_members_remove(member);


https://gerrit.asterisk.org/#/c/10048/2/apps/app_queue.c@6793
PS2, Line 6793: 			ast_autoservice_chan_hangup_peer(qe->chan, peer);
              : 			ao2_ref(member, -1);
Need to put the following between these two lines here for the same reason: We have not bridged the caller and peer yet.

pending_members_remove(member);



-- 
To view, visit https://gerrit.asterisk.org/10048
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib780fbf48ace9d2d8eaa1270b9d530a4fc14c855
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Cao Minh Hiep <chiep at infinitalk.co.jp>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 21 Sep 2018 21:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180921/38a707fc/attachment.html>