[Asterisk-code-review] bridges: Remove reliance on stasis caching (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10227 )

Change subject: bridges:  Remove reliance on stasis caching
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/10227/1/include/asterisk/stasis_bridges.h
File include/asterisk/stasis_bridges.h:

https://gerrit.asterisk.org/#/c/10227/1/include/asterisk/stasis_bridges.h@73
PS1, Line 73:  * \since 13.24
            :  * \since 15.6
            :  * \since 16.1
> Delete these as this is master only

I thought I got all of these.


https://gerrit.asterisk.org/#/c/10227/1/main/stasis_bridges.c
File main/stasis_bridges.c:

https://gerrit.asterisk.org/#/c/10227/1/main/stasis_bridges.c@1374
PS1, Line 1374:  * \since 12.0.0
> delete

oops, cut and pastes from bridges.c


https://gerrit.asterisk.org/#/c/10227/1/res/ari/resource_bridges.c
File res/ari/resource_bridges.c:

https://gerrit.asterisk.org/#/c/10227/1/res/ari/resource_bridges.c@912
PS1, Line 912: 			ao2_ref(snapshots, -1);
             : 			ast_ari_response_alloc_failed(response);
             : 			return;
             : 		}
             : 	}
             : 	ao2_iterator_destroy(&i);
             : 	ao2_ref(snapshots, -1);
> Looks like "snapshots" is being unref'd twice? Once for each of
 > these paths and then once by the RAII_VAR?
 > 
 > If that's the case these two snapshot unrefs can be removed.

Thought I got these.  Hmmm.  I have to test for reference leaks again.



-- 
To view, visit https://gerrit.asterisk.org/10227
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7049b80efa88676ce5c4666f818fa18ad1985369
Gerrit-Change-Number: 10227
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 21 Sep 2018 18:49:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180921/a64eb5c9/attachment.html>