[Asterisk-code-review] rtp engine: rtcp report to json can overflow the ssrc intege... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10151 )

Change subject: rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10151/4/configure.ac
File configure.ac:

https://gerrit.asterisk.org/#/c/10151/4/configure.ac@691
PS4, Line 691: 	JANSSON_DEFINE_JSON_INT()
This should probably pass $JANSSON_INCLUDE to deal with any packaged version where the header is not in /usr/include/jansson.h.


https://gerrit.asterisk.org/#/c/10151/4/configure.ac@787
PS4, Line 787: AC_CHECK_FUNCS([asprintf atexit closefrom dup2 eaccess endpwent euidaccess ffsll ftruncate getcwd gethostbyname gethostname getloadavg gettimeofday glob ioperm inet_ntoa isascii memchr memmove memset mkdir mkdtemp munmap newlocale ppoll putenv re_comp regcomp select setenv socket strcasecmp strcasestr strchr strcspn strdup strerror strlcat strlcpy strncasecmp strndup strnlen strrchr strsep strspn strstr strtod strtol strtoll strtold strtoq unsetenv uselocale utime vasprintf getpeereid sysctl swapctl])
Not a big deal but this change is no longer needed.


https://gerrit.asterisk.org/#/c/10151/4/third-party/jansson/configure.m4
File third-party/jansson/configure.m4:

https://gerrit.asterisk.org/#/c/10151/4/third-party/jansson/configure.m4@98
PS4, Line 98: 			[exit(!JSON_INTEGER_IS_LONG_LONG || sizeof(json_int_t) != sizeof(long long));])],
I don't think we should do the sizeof comparison.  We could do:
#if !JSON_INTEGER_IS_LONG_LONG
#error "not long long"
#endif

This would work with AC_COMPILE_IFELSE and which is cross-compile compatible.



-- 
To view, visit https://gerrit.asterisk.org/10151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
Gerrit-Change-Number: 10151
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 21 Sep 2018 17:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180921/dc475ff9/attachment-0001.html>