[Asterisk-code-review] res remb modifier: Add module for controlling REMB from CLI. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Sep 20 11:08:26 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10205 )

Change subject: res_remb_modifier: Add module for controlling REMB from CLI.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10205/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10205/1//COMMIT_MSG@11
PS1, Line 11: and is
            : useful for demonstrations.
> Is this the only value added? If strictly for demo purposes I lean toward this not being part of the […]
It is also useful for testing/debugging since you can explicitly control the value and see the result. It could also be used as a base in the future for an interface if we so wanted.



-- 
To view, visit https://gerrit.asterisk.org/10205
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib089427c46a4a36d645cecfe02406adb38c17bec
Gerrit-Change-Number: 10205
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 16:08:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180920/6795a287/attachment.html>


More information about the asterisk-code-review mailing list